Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generated model classes don't have generic lombok Setter annotation #6102

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: generated model classes don't have generic lombok Setter annotation #6102

merged 2 commits into from
Jul 3, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 2, 2024

Description

Fixes #6100

Add specific setAdditionalProperties setter method instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

manusa added 2 commits July 2, 2024 15:55
@manusa
fix: generated model classes don't have generic lombok Setter annotation
38ce38e 
Add specific setAdditionalProperties setter method instead.

Signed-off-by: Marc Nuri <[email protected]>
@manusa
fix: generated model classes don't have generic lombok Setter annotat…
c30a8ff 
…ion (generated)

Add specific setAdditionalProperties setter method instead.

Signed-off-by: Marc Nuri <[email protected]>
This was referenced Jul 2, 2024
Closed
Closed
@manusa manusa added this to the 7.0.0 milestone Jul 2, 2024 — with automated-tasks
shawkins
shawkins approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the goal is to eventually remove lombok, then we have to take on this responsibility

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manusa
Copy link
Member Author

manusa commented Jul 3, 2024

the goal is to eventually remove lombok, then we have to take on this responsibility

The goal is to replace this generator with something simpler (see #6100 (comment)).
I've got something mostly working now, but I still prefer to do some easy simplifications to the legacy model generator beforehand (mostly those that involve generating invalid or redundant code -such as this one-).

@manusa manusa merged commit 54ae55c into fabric8io:main Jul 3, 2024
20 of 21 checks passed
@manusa manusa deleted the fix/lombok-setter branch July 3, 2024 05:30
@manusa manusa self-assigned this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawkins shawkins shawkins approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Model has lombok.Setter when is not needed
2 participants
@manusa @shawkins